Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase code coverage #264

Merged
merged 3 commits into from
May 16, 2024
Merged

Increase code coverage #264

merged 3 commits into from
May 16, 2024

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented May 16, 2024 •
edited
Loading

Various additional tests and a few bug fixes inspired by code coverage

Versions

  • Bump DI to v0.4.1

DI source

  • Coloring: remove dead code

DI extensions

  • FiniteDiff: remove dead code
  • FiniteDifferences: fix unused pullback due to missing seed in preparation
  • ForwardDiff: remove dead code
  • Symbolics: remove dead code

DI tests

  • Move coloring tests here from DIT
  • Add tests on ForwardDiff with custom tag
  • Add tests for Symbolics sparsity detector until Add ADTypes sparsity detector JuliaSymbolics/Symbolics.jl#1134 can be merged
  • Add more tests for missing backends: f and f!, "load backend" and "open issue"
  • Add boilerplate tests for SecondOrder

DIT tests

  • Add global LOGGING toggle
  • Add manual tests for the structural orthogonality check functions

@gdalle gdalle marked this pull request as ready for review May 16, 2024 09:49
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.03%. Comparing base (d5420a1) to head (379f89b).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #264      +/-   ##
==========================================
+ Coverage   95.14%   96.03%   +0.88%     
==========================================
  Files          74       75       +1     
  Lines        3934     3908      -26     
==========================================
+ Hits         3743     3753      +10     
+ Misses        191      155      -36

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle merged commit fe4ba4c into main May 16, 2024
7 checks passed
@gdalle gdalle deleted the gd/cov branch May 16, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gdalle @codecov-commenter